remove debug statements#521
Merged
chriselrod merged 1 commit intoJuliaSIMD:mainfrom Jan 4, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 80.29% 80.11% -0.19%
==========================================
Files 39 39
Lines 9608 9604 -4
==========================================
- Hits 7715 7694 -21
- Misses 1893 1910 +17 ☔ View full report in Codecov by Sentry. |
Member
|
Oops, I did not mean to add those. |
Member
Author
|
Thanks for merging this so quickly! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These debug statements were added in #519. They made CI fail in ranocha/SummationByPartsOperators.jl#241. I think it would be nice to disable them again (or only enable them with a special debug setting?).
It would be nice to get a new release when this is merged.